[NFC] Function extraction and renaming of variable for shorter refere… #11278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRM/Price/BAO/LineItem.php
Outdated
| ($submittedLineItems[$previousLineItem['price_field_value_id']]['line_total'] == 0 && $submittedLineItems[$previousLineItem['price_field_value_id']]['qty'] == 1) || | ||
| ($previousLineItem['qty'] != $submittedLineItems[$previousLineItem['price_field_value_id']]['qty']) | ||
| if (($previousLineItem['line_total'] != $submittedLineItem['line_total']) | ||
| || |
There was a problem hiding this comment.
should this go on the previous line?
There was a problem hiding this comment.
not sure - at some point I liked it better on the next line - it was a deliberate change - but may I was just in a 'next liney mood'
There was a problem hiding this comment.
Minor aesthetic, but seems kind of weird to me to have the || on a line by itself :
There was a problem hiding this comment.
I don't know if it 'looks' right - but the change I just pushed is the most readable to me - ie. having the inners of the OR's separated out
eileenmcnaughton
force-pushed
the
towards1
branch
3 times, most recently
from
d9f5efe
to
862ddc0
Compare
…nce. This is a function extraction towards CRM-19273. I haven't changed the logic but it is apparent that we are changing the contribution financial type to 'the financial type of the last line item' - which is a little dubious although it might work in practice. We should expose the field & let people choose it
eileenmcnaughton
force-pushed
the
towards1
branch
from
862ddc0
to
5617feb
Compare
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
[NFC] Function extraction and renaming of variable for shorter refere…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a function extraction towards CRM-19273. I haven't changed the logic but it is apparent that
we are changing the contribution financial type to 'the financial type of the last line
item' - which is a little dubious although it might work in practice. We should expose the field &
let people choose it
Before
code is in main function
After
code is extracted
Technical Details
This is breakdown of changes in #10962